Fix egress interfaces script to work on IPI clusters #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
fix/egress-interfaces-machineconfig
branch
2 times, most recently
from
b63133c to
a995b2a
Compare
DebakelOrakel
approved these changes
Aug 6, 2024
We adjust the script to use the external API DNS record (api.<cluster-domain>) instead of api-int, so that it works without any problems on IPI clusters which provide the api-int record via in-cluster CoreDNS which isn't running yet before the kubelet is started.
simu
force-pushed
the
fix/egress-interfaces-machineconfig
branch
from
a995b2a to
0425f8a
Compare
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We adjust the script to use the external API DNS record (api.) instead of api-int, so that it works without any problems on IPI clusters which provide the api-int record via in-cluster CoreDNS which isn't running yet before the kubelet is started.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.