[FEATURE] - Adding Custom Labels #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsheepuk
reviewed
Nov 14, 2023
| @@ -80,6 +80,9 @@ spec: | |||
| {{- if .Values.controller.templates.job }} | |||
| - --job-template={{ .Values.controller.templates.job }} | |||
| {{- end }} | |||
| {{- range $key, value = Values.controller.jobLabels }} | |||
| - --job-label={{ $key }}={{ $value }} | |||
| {{- end }} | |||
There was a problem hiding this comment.
Oh I see what you mean about CLI parameter now 👍
gambol99
changed the title
Adding the ability to add additional labels on the pods which run the terraform
gambol99
force-pushed
the
feat_labels_and_annotations
branch
from
4e2f431 to
5f3464c
Compare
mrsheepuk
reviewed
Nov 14, 2023
| items := strings.Split(item, "=") | ||
| if len(items) != 2 { | ||
| return nil, errors.New("invalid key=value pair found in slice") | ||
| } |
There was a problem hiding this comment.
where would these errors come out, would they be surfaced to a user? Could it be better to log and silently ignore invalid values?
There was a problem hiding this comment.
eekk .. too late :-D ..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to add additional labels on the pods which run the terraform