Cherry pick regen road functionality #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
araffin
requested changes
May 19, 2019
| 'rand_seed': rand_seed.__str__(), | ||
| 'turn_increment': turn_increment.__str__()} | ||
|
|
||
| self.sock.queue_message(msg) |
There was a problem hiding this comment.
why not self.queue_message(msg)?
| @@ -315,6 +315,22 @@ def send_control(self, steer, throttle): | |||
| msg = {'msg_type': 'control', 'steering': steer.__str__(), 'throttle': throttle.__str__(), 'brake': '0.0'} | |||
| self.queue_message(msg) | |||
|
|
|||
| def send_regen_road(self, road_style=0, rand_seed=0, turn_increment=0.0): | |||
| ''' | |||
There was a problem hiding this comment.
Please use double quotes and follow the docstring style ;) (:param road_style: (int) ...)
There was a problem hiding this comment.
Will rework this PR according to https://github.com/hill-a/stable-baselines
|
Hello, I added those changes in my new PR #9 (which require master version of stable-baselines, that's why I did not merge it yet) |
|
Great! Closing this PR since it looks to be redundant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick this functionality from https://github.com/tawnkramer/sdsandbox/blob/master/src/predict_server.py#L120-L134 to send a directive to the simulator to regenerate the road.
Usage example: