Enhanced Hooks with Outside Click Handling and Dark Mode Detection #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@adarsh-jha-dev is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report
@@ Coverage Diff @@
## main #654 +/- ##
=======================================
Coverage 18.23% 18.23%
=======================================
Files 59 59
Lines 2731 2731
=======================================
Hits 498 498
Misses 2233 2233 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dartpain
approved these changes
Oct 23, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
Why was this change needed? (You can also link to an open issue here)
useOutsideAlerter: This change was needed to enhance the useOutsideAlerter hook by adding the ability to handle clicks outside a specified ref element and optionally handle the 'Escape' key press. This addition allows for more robust handling of click events in various components, such as modals and popovers.
useMediaQuery: The change was also necessary to expand the useMediaQuery hook's functionality. It now includes the detection of dark mode using the prefers-color-scheme: dark media query. This update provides a more comprehensive way to adapt UI elements to the user's system-wide preferences.
Other information:
No additional information is required for this change.