-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Hero section styling fixed, made responsive across all devices #679
Conversation
@akash0708 is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@dartpain can you please review the PR and let me know if any further changes are needed? |
Hello @dartpain , please let me know if any further changes will be necessary! |
Codecov Report
@@ Coverage Diff @@
## main #679 +/- ##
==========================================
+ Coverage 18.26% 18.99% +0.72%
==========================================
Files 59 61 +2
Lines 2743 2817 +74
==========================================
+ Hits 501 535 +34
- Misses 2242 2282 +40 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@dartpain I had not been able to check it on Firefox, after following the quickstart guide I am being able to run it on Chrome and Edge, but on Firefox these are the errors that I'm getting: |
Looks good on chrome and safari, but cant replicate your error on firefox. Can you give it anothere try please |
Hi @dartpain , I think I've been able to fix the Firefox issue. Please check and let me know if any further changes are required. Here is a screenshot of how it looks in Firefox on my device: |
@dartpain can you check if it's alright? |
I see, the problem starts occurring when the number of lines of text inside the divs change. |
Hopefully, this should do the trick. But if it doesn't please let me know @dartpain . |
Great commit, works very well! |
Thank you so much for merging my PR! Loved working on it! |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR fixes the bug on the hero component, which was not behaving as expected on different devices.
Why was this change needed? (You can also link to an open issue here)
The change was requested in issue 🐛 Bug Report: Fix features on hero #581
Other information:
Here are some screenshots that can help in understanding the changes I have made.
Laptop and desktops:
Smartphones:
iPad Air and similar devices:
iPad mini and similar devices: