Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hero section styling fixed, made responsive across all devices #679

Merged
merged 3 commits into from
Oct 29, 2023

Conversation

akash0708
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    This PR fixes the bug on the hero component, which was not behaving as expected on different devices.

  • Why was this change needed? (You can also link to an open issue here)
    The change was requested in issue 🐛 Bug Report: Fix features on hero #581

  • Other information:
    Here are some screenshots that can help in understanding the changes I have made.

Laptop and desktops:

image

Smartphones:

image

iPad Air and similar devices:

image

iPad mini and similar devices:

image

@vercel
Copy link

vercel bot commented Oct 24, 2023

@akash0708 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2023 9:39pm
nextra-docsgpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2023 9:39pm

@akash0708
Copy link
Contributor Author

@dartpain can you please review the PR and let me know if any further changes are needed?

@akash0708
Copy link
Contributor Author

Hello @dartpain , please let me know if any further changes will be necessary!

@dartpain
Copy link
Contributor

dartpain commented Oct 25, 2023

Here is how it looks on firefox
Thank you!
Screenshot 2023-10-25 at 21 13 24

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #679 (d2e4d6e) into main (0668fea) will increase coverage by 0.72%.
Report is 91 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #679      +/-   ##
==========================================
+ Coverage   18.26%   18.99%   +0.72%     
==========================================
  Files          59       61       +2     
  Lines        2743     2817      +74     
==========================================
+ Hits          501      535      +34     
- Misses       2242     2282      +40     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@akash0708
Copy link
Contributor Author

@dartpain I had not been able to check it on Firefox, after following the quickstart guide I am being able to run it on Chrome and Edge, but on Firefox these are the errors that I'm getting:

image

@dartpain
Copy link
Contributor

Looks good on chrome and safari, but cant replicate your error on firefox. Can you give it anothere try please

@akash0708
Copy link
Contributor Author

Hi @dartpain , I think I've been able to fix the Firefox issue. Please check and let me know if any further changes are required.

Here is a screenshot of how it looks in Firefox on my device:
image

@akash0708
Copy link
Contributor Author

@dartpain can you check if it's alright?

@dartpain
Copy link
Contributor

@akash0708
Copy link
Contributor Author

I see, the problem starts occurring when the number of lines of text inside the divs change.

@akash0708
Copy link
Contributor Author

Hopefully, this should do the trick. But if it doesn't please let me know @dartpain .

@dartpain
Copy link
Contributor

Great commit, works very well!

@dartpain dartpain merged commit 46817c7 into arc53:main Oct 29, 2023
8 checks passed
@akash0708
Copy link
Contributor Author

Thank you so much for merging my PR! Loved working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Fix features on hero
2 participants