Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: enhance mobile responsiveness of Hero Page final #752

Merged
merged 9 commits into from
Oct 31, 2023

Conversation

varundhand
Copy link
Contributor

  • What kind of change does this PR introduce?

  • This PR introduces a new feature to improve the mobile responsiveness of the website.

  • Why was this change needed?

  • Fixes issue 🚀 Feature: Improve Mobile Responsiveness for Home Page #682

  • Previously, users had to scroll down on mobile devices to access the input field on the home page. This change enhances the user experience by ensuring that the input field is immediately visible, eliminating the need for unnecessary scrolling.

  • Other information:

  • Before:
    Screenshot 2023-10-24 at 6 46 15 PM

  • After:

Screenshot 2023-10-24 at 6 21 32 PM

Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 11:02pm
nextra-docsgpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 11:02pm

Copy link

vercel bot commented Oct 31, 2023

@varundhand is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

style: formatting API-docs close parenthesis comment core/settings.py
@varundhand
Copy link
Contributor Author

@dartpain is it fine now?

@dartpain
Copy link
Contributor

Nearly done. But now this thing
Screenshot 2023-10-31 at 17 27 42

Is broken on firefox. This bug was fixed recently, try to check out recent code for those boxes to make sure it does not break

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #752 (353e24f) into main (6fc31dd) will not change coverage.
Report is 141 commits behind head on main.
The diff coverage is 58.82%.

@@           Coverage Diff           @@
##             main     #752   +/-   ##
=======================================
  Coverage   19.69%   19.69%           
=======================================
  Files          62       62           
  Lines        2844     2844           
=======================================
  Hits          560      560           
  Misses       2284     2284           
Files Coverage Δ
application/core/settings.py 100.00% <100.00%> (ø)
application/llm/llm_creator.py 69.23% <100.00%> (ø)
application/api/answer/routes.py 25.55% <50.00%> (ø)
application/llm/anthropic.py 95.83% <95.83%> (ø)
application/parser/file/openapi3_parser.py 91.89% <91.89%> (ø)
scripts/parser/file/openapi3_parser.py 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@varundhand
Copy link
Contributor Author

Hi @dartpain Its gonna be tough for me to fix it right now because I have my exams from tomorrow. Is it okay if I fix this within a few days? I have been working on it for two weeks now, why not give it a few more days lol

@dartpain
Copy link
Contributor

Absolutely no worries, please take your time

@dartpain
Copy link
Contributor

Good luck on your exams!

@varundhand
Copy link
Contributor Author

@dartpain thank you so much! Also, will I be eligible for the swag now?

@dartpain
Copy link
Contributor

There is a seven day period, until Noveber 7th we will review everything.

Basically if you finish this PR and it works -> you will get the swag

@varundhand
Copy link
Contributor Author

Sure thing, 7 days are more than enough! Thanks again!

@varundhand
Copy link
Contributor Author

I fixed the container for firefox, it looks like this now:

Screenshot 2023-11-01 at 3 55 57 AM

@dartpain dartpain merged commit 693bdeb into arc53:main Oct 31, 2023
8 checks passed
@dartpain
Copy link
Contributor

Thank you! @holopin-bot @varundhand

Copy link

holopin-bot bot commented Oct 31, 2023

Congratulations @varundhand, you just earned a badge! Here it is: https://holopin.io/claim/cloey36ec147190fjtub2jfrth

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants