Fix form Reset & Form TextArea Style #286
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rco-design-mobile into fix-form-reset-xzq
ziqisia
reviewed
Sep 23, 2024
| @@ -78,14 +92,30 @@ class FormItemInner extends PureComponent<IFormItemInnerProps, IFormItemInnerSta | |||
| return this._touched; | |||
| }; | |||
|
|
|||
| validateField = (): Promise<IFieldError> => { | |||
| getAllRuleValidateTriggers = (): string[] => { | |||
| import { IRules, ValidatorError } from '@arco-design/mobile-utils'; | ||
|
|
||
| import { IRules, ValidatorError, isArray, isObject } from '@arco-design/mobile-utils'; | ||
| import cloneDeepWith from 'lodash/cloneDeepWith'; |
| break; | ||
| default: | ||
| const originTrigger = children.props[trigger]; | ||
| if (triggerPropsField) { |
adaex
added
the
WIP
There was a problem hiding this comment.
Copilot reviewed 6 out of 12 changed files in this pull request and generated 1 suggestion.
Files not reviewed (6)
- packages/arcodesign/components/form/demo/style/mobile.less: Language not supported
- packages/arcodesign/components/form/style/index.less: Language not supported
- packages/arcodesign/components/input/test/snapshots/index.spec.js.snap: Language not supported
- packages/common-widgets/package-lock.json: Language not supported
- packages/arcodesign/components/form/type.ts: Evaluated as low risk
- packages/arcodesign/components/input/index.tsx: Evaluated as low risk
Comments skipped due to low confidence (2)
packages/arcodesign/components/form/demo/custom-item.md:37
- [nitpick] The key 'names' should be singular to match the convention used in other parts of the code. Consider renaming it to 'name'.
names: [{
packages/arcodesign/components/form/demo/custom-item.md:126
- [nitpick] The placeholder text 'Please input age' should be 'Please input your age' for better clarity.
<Input placeholder="Please input age" clearable border="none" onInput={handleInput}/>
| > | ||
| <Form.Item field="name" label="UserName" trigger="onBlur" rules={rules.name} required> | ||
| <Input placeholder="Please input username" clearable border="none" /> | ||
| </Form.Item> | ||
| <Form.Item field="age" label="Age" trigger="onInput" rules={[{type: 'number', min: 12, validateLevel: 'warning'}]}> | ||
| <Input placeholder="Please input age" clearable border="none" onInput={handleInput}/> | ||
| <Form.Item field="age" label="Age" trigger="onInput" rules={[{type: 'number', min: 12, validateLevel: 'warning'}]} initialValue={11}> |
There was a problem hiding this comment.
The initial value for the 'Age' field is set to 11, which violates the validation rule that specifies a minimum value of 12. Change the initial value to 12 or higher.
Suggested change
| <Form.Item field="age" label="Age" trigger="onInput" rules={[{type: 'number', min: 12, validateLevel: 'warning'}]} initialValue={11}> | |
| <Form.Item field="age" label="Age" trigger="onInput" rules={[{type: 'number', min: 12, validateLevel: 'warning'}]} initialValue={12}> |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.