Remove inappropriate CP2105 VID/PID association from Tian board definition #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ition Arduino board definitions may associate unique properties of a port. These are used by convenience features in the Arduino development tools that identify a port as a specific Arduino board. In the case of boards that connect to the host computer via a virtual COM port, that identifier is the USB VID/PID pair. This association should only be done with properties that are unique to the board. For most official Arduino boards, this is possible because Arduino creates dedicated VID/PID pairs for that product. In the case of the Tian, a general purpose Silicon Labs CP2105 chip was selected as the USB interface. The board has the manufacturer supplied VID/PID pair 10C4:EA70. In this case it is irresponsible to associate that VID/PID pair with a board definition because any arbitrary device might have this VID/PID. The ports list will be confusing for users who have a CP2105 connected to their computer (whether it is on a 3rd party board or some other unrelated hardware).
|
Memory usage change @ 08c7610
Click for full report table
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arduino board definitions may associate unique properties of a port:
https://arduino.github.io/arduino-cli/latest/pluggable-discovery-specification/#board-identification
https://arduino.github.io/arduino-cli/latest/platform-specification/#board-vidpid
These are used by convenience features in the Arduino development tools that identify a port as a specific Arduino board.
In the case of boards that connect to the host computer via a virtual COM port, that identifier is the USB VID/PID pair.
This association should only be done with properties that are unique to the board. For most official Arduino boards, this is possible because Arduino creates dedicated VID/PID pairs for that product. In the case of the Tian, a general purpose Silicon Labs CP2105 chip was selected as the USB interface. The board has the manufacturer supplied VID/PID pair 10C4:EA70. In this case it is irresponsible to associate that VID/PID pair with a board definition because any arbitrary device might have this VID/PID. The ports list will be confusing for users who have a CP2105 connected to their computer (whether it is on a 3rd party board or some other unrelated hardware).