Added BUFFER_LENGTH macro in Wire.h #693
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added this macro to simplify changing the buffer size Matching [AVR core](https://github.com/arduino/ArduinoCore-avr/blob/master/libraries/Wire/src/Wire.h#L29) and [Arduino docs](https://support.arduino.cc/hc/en-us/articles/4406686928786-Modify-the-buffer-size-of-the-Wire-library)
|
|
|
Memory usage change @ 847a471
Click for full report table
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added this macro to simplify changing the buffer size
Matching AVR core and Arduino docs
Context:
I needed to increase the rx buffer size to use the MLX90640 thermal camera.
At startup, the board retrieve the settings of the camera and this operation needed a 1664 bytes size buffer.
Even after startup, each reading is 1536 bytes size, definitively more than the 256 default bytes size buffer.
The BUFFER_LENGTH macro exist on AVR core and simplify editing the buffer size. Furthermore there is an official Arduino articles on it. I think it could be a good thing to add this macro on others Arduino platforms, not only AVR.