Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bufferAlgorithm params in the open command #1002

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dido18
Copy link
Contributor

@dido18 dido18 commented Jan 10, 2025

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

Remove the bufferAlgorithm argument from the open command.

Current command:
`"open [bufferAlgorithm: ({default}, timed, timedraw)]",

New command:
`"open ",

Use the timed algorithm by default.

Reasons: the Arduino projects use only the timed algorithm. No need for the other two options.
- Editor uses only the timed option.
- Arduino-create-agent-js-client use only the timed option.

  • What is the current behavior?
  • What is the new behavior?
  • Does this PR introduce a breaking change?
    ⚠️ breaking change ⚠️

The open command ignores the bufferAlgorithm option.
It used the timed algorithm by default.

  • Other information:

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 20.84%. Comparing base (67db428) to head (98b6376).

Files with missing lines Patch % Lines
serialport.go 0.00% 9 Missing ⚠️
bufferflow_timed.go 0.00% 1 Missing ⚠️
conn.go 0.00% 1 Missing ⚠️
hub.go 0.00% 1 Missing ⚠️
serial.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1002      +/-   ##
==========================================
+ Coverage   20.14%   20.84%   +0.69%     
==========================================
  Files          42       40       -2     
  Lines        3221     3113     -108     
==========================================
  Hits          649      649              
+ Misses       2487     2379     -108     
  Partials       85       85              
Flag Coverage Δ
unit 20.84% <0.00%> (+0.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jan 10, 2025
@dido18 dido18 changed the title chore(hub.go): remove bufferAlgorithm params in the open command remove bufferAlgorithm params in the open command Jan 10, 2025
@dido18 dido18 force-pushed the remove-open-not-used-buffer-algorithm branch from d3ec8c8 to 679a319 Compare January 10, 2025 13:59
@dido18 dido18 force-pushed the remove-open-not-used-buffer-algorithm branch from 786ac2b to 98b6376 Compare January 10, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants