Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump actions/checkout from 3 to 4 #2257

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 12, 2023

Bumps actions/checkout from 3 to 4.

Release notes

Sourced from actions/checkout's releases.

v4.0.0

What's Changed

New Contributors

Full Changelog: actions/checkout@v3...v4.0.0

v3.6.0

What's Changed

New Contributors

Full Changelog: actions/checkout@v3.5.3...v3.6.0

v3.5.3

What's Changed

New Contributors

Full Changelog: actions/checkout@v3...v3.5.3

v3.5.2

What's Changed

Full Changelog: actions/checkout@v3.5.1...v3.5.2

v3.5.1

What's Changed

New Contributors

... (truncated)

Changelog

Sourced from actions/checkout's changelog.

Changelog

v4.1.0

v4.0.0

v3.6.0

v3.5.3

v3.5.2

v3.5.1

v3.5.0

v3.4.0

v3.3.0

v3.2.0

v3.1.0

v3.0.2

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the topic: infrastructure Related to project infrastructure label Oct 12, 2023
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Linux build of Arduino IDE is dynamically linked against the glibc shared library. This results in it having a dependency on the version of the library that happens to be present in the environment it is built in. The container the Linux build runs in is intentionally configured to have an older version of glibc (#2253). This provides compatibility with a reasonable range of older distro versions that might be present on the Linux machines of Arduino IDE users (newer versions of glibc are compatible with executables linked against an older version but the reverse is not true).

Unfortunately version 4.x of the actions/checkout GitHub Actions action used by the build job has a dependency on a higher version of glibc than is provided by the Linux container. That dependency mismatch is the case of the error that occurs at the action's step in the job after the bump proposed by this PR:

https://github.com/arduino/arduino-ide/actions/runs/6500322388/job/17655503700?pr=2257#step:4:1

Run actions/checkout@v4
/usr/bin/docker exec  e664496daf8282f381bb449ea729006804f386f336833df2aa88e887ffd6b3ef sh -c "cat /etc/*release | grep ^ID"
/__e/node20/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /__e/node20/bin/node)

This is the reason the workflow was intentionally configured to use actions/checkout@v3 for the Linux build job. So it is necessary to decline this bump.

Dependabot will remember this decision and only submit another PR for bumping actions/checkout at such time the action has another major version bump (i.e., v5 -> v6). At that time, we should accept the bump in all workflow steps other than this specific step, which must remain at actions/checkout@v3 unless we eventually abandon support for the older distro versions and update the container so that a newer version of glibc is available.

@per1234
Copy link
Contributor

per1234 commented Oct 12, 2023

@dependabot ignore this major version

@dependabot dependabot bot closed this Oct 12, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 12, 2023

OK, I won't notify you about version 4.x.x again, unless you re-open this PR.

@dependabot dependabot bot deleted the dependabot/github_actions/actions/checkout-4 branch October 12, 2023 20:21
@per1234 per1234 added type: enhancement Proposed improvement conclusion: invalid Issue/PR not valid labels Oct 12, 2023
@per1234 per1234 added the os: linux Specific to Linux operating system label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid os: linux Specific to Linux operating system topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant