Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M5AtomS3 #2352

Merged
merged 1 commit into from
Jan 9, 2023
Merged

M5AtomS3 #2352

merged 1 commit into from
Jan 9, 2023

Conversation

Tinyu-Zhao
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Jan 9, 2023
@github-actions github-actions bot merged commit c7f141f into arduino:main Jan 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/m5stack/M5AtomS3/

github-actions bot pushed a commit that referenced this pull request Jan 9, 2023
@Tinyu-Zhao
Copy link
Contributor Author

@per1234 Hello, I don't know why I have this error in my repository, can you help me?

image

@per1234
Copy link
Contributor

per1234 commented Jan 11, 2023

Hi @Tinyu-Zhao. Thanks for your report.

Explanation

The cause of the error is you have a submodule named MahonyAHRS here:

https://github.com/m5stack/M5AtomS3/tree/0.0.1/examples/Basics/FactoryTest/lib

but your repository does not contain an accompanying .gitmodules configuration file. Even though Git allows you to produce such conditions in a Git repository, it is not a valid submodule without that configuration file. Unfortunately it seems the github.com/go-git/go-git Go module our libraries-repository-engine tool uses for the Git operations on the library repositories doesn't know how to handle an invalid submodule like this, so it considers the repository to be in a "dirty" state after checking out the tag. Since we previously had some problems with incorrect linter results due to a library repository being left in a "dirty" state after checkout, we now check for that condition and reject the release out of caution if it is found to be dirty (which it should never be if the Git checkout code is working as it should): arduino/libraries-repository-engine#42

Workaround

You can work around the problem by doing the following:

  1. Either add the .gitmodules file if you need the submodule or else remove the submodule from your repository.
  2. Update the version value in the library.properties file.
  3. Create a new release or tag in the library repository.

libraries-repository-engine will still reject your 0.0.1 release, but it will accept the new release.

Follow up

I have created an issue to track this defect in libraries-repository-engine:

arduino/libraries-repository-engine#164

There is more information about the problem there if you are interested.

@Tinyu-Zhao
Copy link
Contributor Author

Tinyu-Zhao commented Jan 14, 2023

Thank for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants