Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+tflm_esp32,+tflm_cortexm,-EloquentTensorFlowX #3822

Closed
wants to merge 0 commits into from
Closed

+tflm_esp32,+tflm_cortexm,-EloquentTensorFlowX #3822

wants to merge 0 commits into from

Conversation

eloquentarduino
Copy link
Contributor

No description provided.

Copy link
Contributor

Hi @eloquentarduino.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added the topic: modification Change existing list entry label Dec 30, 2023
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/eloquentarduino/tflm_esp32:

Linting library in tflm_esp32
ERROR: Library name tflm_esp32 not found in the Library Manager index. Library names are not allowed to change after    
       being added to the index.                                                                                        
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     
WARNING: library.properties maintainer value Simone Salerno,eloquentarduino@gmail.com contains "Arduino". 3rd party     
         libraries are not maintained by Arduino.                                                                       
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP057)                                                                                                   
WARNING: No readme found. Please document your library.                                                                                
         See:                                                                                                                          
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes
         (Rule LD001)                                                                                                                  
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 1 ERRORS, 3 WARNINGS

-------------------

Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/eloquentarduino/tflm_cortexm:

Linting library in tflm_cortexm
ERROR: Library name tflm_cortexm not found in the Library Manager index. Library names are not allowed to change after  
       being added to the index.                                                                                        
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     
WARNING: library.properties maintainer value Simone Salerno,eloquentarduino@gmail.com contains "Arduino". 3rd party     
         libraries are not maintained by Arduino.                                                                       
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP057)                                                                                                   
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 1 ERRORS, 2 WARNINGS

-------------------

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @eloquentarduino
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 December 30, 2023 15:44
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eloquentarduino. There are two distinct operations here:

  • Submit "tflm_esp32" and "tflm_cortexm" libraries
  • Remove "EloquentTensorFlow32" and "EloquentTensorFlowCortexM" libraries

Please submit a separate pull request for each of those operations. The reason I am asking you to do this is that we have a completely automated system for handling submissions, but removal requests are handled manually. The submission handling system only works on pull requests that consist exclusively of submissions (it is fine to submit multiple libraries in a single PR). So if you split this into two pull requests then the PR that consists purely of submissions will be accepted immediately and the PR that consists purely of removal requests will be easier for the maintainers to manage.

@per1234 per1234 self-assigned this Dec 31, 2023
@per1234 per1234 added status: waiting for information More information must be provided before work can proceed topic: submission Add library to the list topic: removal Remove library from the list and removed topic: modification Change existing list entry labels Dec 31, 2023
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Hi @eloquentarduino.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added topic: other Something other than a library list request and removed status: waiting for information More information must be provided before work can proceed topic: submission Add library to the list topic: removal Remove library from the list labels Jan 2, 2024
@github-actions github-actions bot requested a review from per1234 January 2, 2024 18:25
@per1234 per1234 added conclusion: duplicate Has already been submitted topic: submission Add library to the list topic: removal Remove library from the list and removed topic: other Something other than a library list request labels Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted topic: removal Remove library from the list topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants