Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repositories.txt #5732

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update repositories.txt #5732

wants to merge 1 commit into from

Conversation

YoavPaz
Copy link
Contributor

@YoavPaz YoavPaz commented Jan 9, 2025

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

A problem was found with your submission https://github.com/YoavPaz/I2CR-CPP

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Thanks for your interest in contributing to the Arduino Library Manager index @YoavPaz
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YoavPaz
❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗
⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️
⚠️ PLEASE READ THIS IMPORTANT INFORMATION ⚠️
⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️
❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗
@YoavPaz

Hello @YoavPaz. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:

https://github.com/YoavPaz/I2CR-CPP/tree/1.0.0

(note that the library was in a subfolder of the repository at the tagged point in the revision history)

❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.

❗❗❗ DO NOT SUBMIT ANOTHER PULL REQUEST. CONTINUE TO USE THIS PULL REQUEST. IF YOU CREATE ANOTHER PULL REQUEST YOU WILL BE PERMANENTLY BANNED ❗❗❗

If you have any questions or concerns, please let me know.

Regards, Per

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants