Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Veil installation issues #287

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nkd3v
Copy link

@nkd3v nkd3v commented Dec 16, 2020

@avidzcheetah
Copy link

Title

Fix: ./setup Directory Not Found

Description

This update resolves the issue where the ./setup directory was not found during the installation process. The fix aligns with the updated installation instructions provided in the [Veil Framework GitHub repository](https://github.com/Veil-Framework/Veil#gits-quick-install).

By addressing this issue, the installation process is now more seamless and adheres to the latest repository structure. This fix ensures better compatibility and reduces errors for users.

Copy link

@avidzcheetah avidzcheetah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Metadata

  • Title: Fixed Veil installation issues
  • Description: Fixed ./setup directory not found. Veil GitHub
  • Author: nkd3v
  • State: Open
  • Additions: 2
  • Deletions: 2
  • Commits: 1
  • Files Changed: 1
  • URL: Pull Request #287

Code Diff

@@ -10429,8 +10429,8 @@ check_if_ks
[10429,10429]         cloned=$?
[10430,10430]         if [[ "$cloned" == 1 ]]
[10431,10431]         then
[10432,10431]-            cd setup
[10433,10431]-            ./setup.sh -c
[10433,10432]+            cd config
[10433,10433]+            ./setup.sh --force --silent
[10434,10434]         fi
[10435,10435]     }
[10436,10436]     function install_leviathan

Review

  1. Directory Change: The directory to navigate has been changed from setup to config. This likely corrects an issue where the setup directory does not exist.
  2. Script Execution: The script execution command has been modified to include --force --silent options, replacing the -c option. This likely ensures the script runs without user interaction and forces the configuration.

Feedback

  • The changes appear to be necessary corrections to ensure the script runs correctly by navigating to the correct directory and providing appropriate options for the script execution.
  • Ensure that the config directory and the --force --silent options are appropriate for the setup script in the new context.

Overall, these changes seem well-intentioned and necessary to resolve the issues described in the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants