Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anta.tests): VerifyUnifiedForwardingTableMode test is now skipped on unsupported platforms #1007

Merged
merged 4 commits into from
Jan 15, 2025
Merged

fix(anta.tests): VerifyUnifiedForwardingTableMode test is now skipped on unsupported platforms #1007

merged 4 commits into from
Jan 15, 2025

Conversation

carl-baillargeon
Copy link
Contributor

Fixes #607

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 15, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1007 will not alter performance

Comparing carl-baillargeon:fix/issue_607 (f4816a9) with main (ba15a4a)

Summary

✅ 22 untouched benchmarks

gmuloc
gmuloc reviewed Jan 15, 2025
View reviewed changes
anta/models.py Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@carl-baillargeon carl-baillargeon merged commit 1be75b8 into aristanetworks:main Jan 15, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

Assignees

@carl-baillargeon carl-baillargeon

Labels
rn: fix(anta.tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VerifyUnifiedForwardingTableMode should be skipped on unsupported platforms
2 participants
@carl-baillargeon @gmuloc