Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(anta): Clean reporter typing #438

Merged
merged 6 commits into from
Oct 27, 2023
Merged

refactor(anta): Clean reporter typing #438

merged 6 commits into from
Oct 27, 2023

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Oct 26, 2023

Description

Spring cleaning

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@gmuloc gmuloc changed the title Refactor(anta): Clean reporter typing refactor(anta): Clean reporter typing Oct 26, 2023
@gmuloc gmuloc added this to the v0.11.0 milestone Oct 27, 2023
mtache
mtache approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@mtache mtache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine !

@mtache mtache merged commit a78db01 into aristanetworks:main Oct 27, 2023
19 checks passed
@titom73 titom73 mentioned this pull request Nov 11, 2023
Merged
@gmuloc gmuloc deleted the clean-reporter-typing branch January 15, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtache mtache mtache approved these changes

Assignees

@gmuloc gmuloc

Labels
rn: refactor(anta)
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gmuloc @mtache