Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anta): Add support of CSV file export #672

Merged
merged 43 commits into from
Jul 17, 2024
Merged

feat(anta): Add support of CSV file export #672

merged 43 commits into from
Jul 17, 2024

Conversation

titom73
Copy link
Collaborator

@titom73 titom73 commented May 13, 2024 •
edited
Loading

Description

Add option to save tests result in CSV format

Command example

# Example 1
anta nrfu -c anta/nrfu.yml csv --csv-output demo.csv

# Example 2
anta nrfu -c anta/nrfu.yml --device spine1 csv --csv-output demo.csv

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

Requirements

@titom73 titom73 added framework-enhancement New feature or request Anta CLI All things around CLI labels May 13, 2024
@titom73 titom73 self-assigned this May 13, 2024
@mtache
Copy link
Collaborator

mtache commented May 14, 2024

What about anta nrfu csv ? :)

@titom73
Copy link
Collaborator Author

titom73 commented May 14, 2024

What about anta nrfu csv ? :)

It means would have no output which is a bit uncommon: running tests and not seing results.

This aproach assumes that you can chose how you want to display and just save results in a CSV file.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@carl-baillargeon carl-baillargeon mentioned this pull request Jul 4, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@titom73 titom73 mentioned this pull request Jul 5, 2024
Merged
6 tasks
@titom73 titom73 force-pushed the feat/csv-export branch from 5fefdce to 13a6b48 Compare July 5, 2024 08:34
titom73 and others added 2 commits July 10, 2024 12:21
@titom73 @carl-baillargeon
Update tests/units/reporter/test_csv.py
c35d721 
Co-authored-by: Carl Baillargeon <carl.baillargeon@arista.com>
@titom73 @carl-baillargeon
Update tests/units/cli/nrfu/test_commands.py
ef2bab7 
Co-authored-by: Carl Baillargeon <carl.baillargeon@arista.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

gmuloc
gmuloc requested changes Jul 10, 2024
View reviewed changes
anta/reporter/csv_reporter.py Outdated Show resolved Hide resolved
anta/reporter/csv_reporter.py Outdated Show resolved Hide resolved
docs/cli/nrfu.md Outdated Show resolved Hide resolved
tests/units/reporter/test_csv.py Outdated Show resolved Hide resolved
titom73 and others added 5 commits July 10, 2024 15:05
@titom73 @gmuloc
Update anta/reporter/csv_reporter.py
e9be744 
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
@titom73 @gmuloc
Update anta/reporter/csv_reporter.py
ccbce5f 
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c6c3a50 
for more information, see https://pre-commit.ci
@titom73
ci: Cleanup pytest
20d63c7
@titom73
fix: Update cli help message
8173f2a
@titom73 titom73 requested a review from gmuloc July 10, 2024 14:10
gmuloc
gmuloc reviewed Jul 12, 2024
View reviewed changes
anta/cli/nrfu/commands.py Outdated Show resolved Hide resolved
gmuloc
gmuloc reviewed Jul 12, 2024
View reviewed changes
anta/reporter/csv_reporter.py Outdated Show resolved Hide resolved
docs/cli/nrfu.md Outdated Show resolved Hide resolved
tests/units/reporter/test_csv.py Outdated Show resolved Hide resolved
@titom73 titom73 requested a review from gmuloc July 16, 2024 13:09
gmuloc
gmuloc reviewed Jul 17, 2024
View reviewed changes
anta/cli/nrfu/utils.py Outdated Show resolved Hide resolved
gmuloc
gmuloc reviewed Jul 17, 2024
View reviewed changes
anta/cli/nrfu/utils.py Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

carl-baillargeon
carl-baillargeon approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc merged commit 25ec15f into aristanetworks:main Jul 17, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@gmuloc gmuloc gmuloc approved these changes

@mtache mtache Awaiting requested review from mtache

Assignees

@titom73 titom73

Labels
Anta CLI All things around CLI framework-enhancement New feature or request rn: feat(anta)
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@titom73 @mtache @gmuloc @carl-baillargeon