Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anta): Added the test case to verify SNMP user #877

Merged
merged 11 commits into from
Jan 14, 2025
Merged

feat(anta): Added the test case to verify SNMP user #877

merged 11 commits into from
Jan 14, 2025

Conversation

vitthalmagadum
Copy link
Collaborator

@vitthalmagadum vitthalmagadum commented Oct 11, 2024 •
edited
Loading

Description

Verifies the SNMP user configurations for specified version(s).

- Verifies that the valid user name and group name.
- Ensures that the SNMP v3 security model, the user authentication and privacy settings aligning with version-specific requirements.

Expected Results
----------------
* Success: The test will pass if the provided SNMP user and all specified parameters are correctly configured.
* Failure: The test will fail if the provided SNMP user is not configured or specified parameters are not correctly configured.

Fixes #852

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 11, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #877 will not alter performance

Comparing vitthalmagadum:issue_852 (91fe14c) with main (5389bb0)

Summary

✅ 22 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
95.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

MaheshGSLAB
MaheshGSLAB reviewed Oct 16, 2024
View reviewed changes
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Conflicts have been resolved. A maintainer will review the pull request shortly.

carl-baillargeon
carl-baillargeon requested changes Jan 8, 2025
View reviewed changes
anta/custom_types.py Outdated Show resolved Hide resolved
anta/custom_types.py Outdated Show resolved Hide resolved
anta/input_models/snmp.py Outdated Show resolved Hide resolved
anta/input_models/snmp.py Outdated Show resolved Hide resolved
anta/input_models/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/input_models/snmp.py Outdated Show resolved Hide resolved
carl-baillargeon
carl-baillargeon reviewed Jan 8, 2025
View reviewed changes
anta/tests/snmp.py Outdated Show resolved Hide resolved
carl-baillargeon
carl-baillargeon requested changes Jan 14, 2025
View reviewed changes
anta/custom_types.py Outdated Show resolved Hide resolved
anta/input_models/snmp.py Outdated Show resolved Hide resolved
anta/input_models/snmp.py Outdated
Comment on lines 37 to 42
base_string = f"User: {self.username}"
if self.group_name:
base_string += f" Group: {self.group_name}"
if self.version:
base_string += f" Version: {self.version}"
return base_string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that group_name and version are required fields, you can update this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Thanks!!

anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
carl-baillargeon
carl-baillargeon approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@carl-baillargeon carl-baillargeon merged commit 8e5de9a into aristanetworks:main Jan 14, 2025
25 checks passed
geetanjalimanegslab pushed a commit to geetanjalimanegslab/anta that referenced this pull request Jan 15, 2025
@vitthalmagadum @carl-baillargeon @geetanjalimanegslab
feat(anta): Added the test case to verify SNMP user (aristanetworks#877)
24028c6 
* Added TC for SNMP user

* Updated input model refactoring changes

* updated documentation apis

* added unit tests for the input models

* addressed review comments: updated docstrings, input model

* updated field validator

* Addressed review comments: updated input model docstrings

* Remove unnecessary TypeVar

---------

Co-authored-by: VitthalMagadum <yvitthal.magadum-ext@arista.com>
Co-authored-by: Carl Baillargeon <carl.baillargeon@arista.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaheshGSLAB MaheshGSLAB MaheshGSLAB left review comments

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@gmuloc gmuloc Awaiting requested review from gmuloc

Assignees

@vitthalmagadum vitthalmagadum

Labels
rn: feat(anta)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the test case to verify SNMP user.
3 participants
@vitthalmagadum @carl-baillargeon @MaheshGSLAB