fix(anta.tests): Cleaning up Services tests module (VerifyErrdisableRecovery) #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
CodSpeed Performance ReportMerging #955 will not alter performanceComparing Summary
|
carl-baillargeon
requested changes
Dec 17, 2024
anta/tests/services.py
Outdated
| continue | ||
|
|
||
| if not all([error_reason.status == (act_status := reason_output["status"]), error_reason.interval == (act_interval := int(reason_output["interval"]))]): | ||
| self.result.is_failure(f"{error_reason} - Incorrect reason details - Status: {act_status} Interval: {act_interval}") |
There was a problem hiding this comment.
Suggested change
| self.result.is_failure(f"{error_reason} - Incorrect reason details - Status: {act_status} Interval: {act_interval}") | |
| self.result.is_failure(f"{error_reason} - Incorrect configuration - Status: {act_status} Interval: {act_interval}") |
carl-baillargeon
requested changes
Jan 8, 2025
|
carl-baillargeon
approved these changes
Jan 14, 2025
geetanjalimanegslab
pushed a commit
to geetanjalimanegslab/anta
that referenced
this pull request
Jan 15, 2025
…ecovery) (aristanetworks#955) * Refactored VerifyErrdisableRecovery test for input models * addressed review comments: updated the input model, docstring * Addressed review comments: updated input models, unit tests for input model * improved the test coverage * removed field validator as 'Field' constraints the input * updated input models and deprecation warning * updated unit test cases * Minor fixes --------- Co-authored-by: Carl Baillargeon <carl.baillargeon@arista.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring Services tests module to address the following issues:
Checklist:
pre-commit run)tox -e testenv)