Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anta.tests): BFD test module: AntaTest.Input subclasses using common input models should have validators for their required fields. #999

Merged
merged 6 commits into from
Jan 14, 2025
Merged

fix(anta.tests): BFD test module: AntaTest.Input subclasses using common input models should have validators for their required fields. #999

merged 6 commits into from
Jan 14, 2025

Conversation

vitthalmagadum
Copy link
Collaborator

Description

BFD test module: AntaTest.Input subclasses using common input models should have validators for their required fields.

Fixes #997

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 8, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #999 will not alter performance

Comparing vitthalmagadum:fix/bfd (d027827) with main (5389bb0)

Summary

✅ 22 untouched benchmarks

carl-baillargeon
carl-baillargeon requested changes Jan 8, 2025
View reviewed changes
anta/tests/bfd.py Outdated Show resolved Hide resolved
anta/tests/bfd.py Outdated Show resolved Hide resolved
anta/tests/bfd.py Outdated Show resolved Hide resolved
carl-baillargeon
carl-baillargeon reviewed Jan 14, 2025
View reviewed changes
anta/tests/bfd.py Outdated Show resolved Hide resolved
anta/tests/bfd.py Outdated Show resolved Hide resolved
tests/units/input_models/test_bfd.py Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

carl-baillargeon
carl-baillargeon approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@carl-baillargeon carl-baillargeon merged commit 1acbdcb into aristanetworks:main Jan 14, 2025
25 checks passed
geetanjalimanegslab pushed a commit to geetanjalimanegslab/anta that referenced this pull request Jan 15, 2025
@vitthalmagadum @geetanjalimanegslab
fix(anta.tests): BFD test module: AntaTest.Input subclasses using com…
35a46a7 
…mon input models should have validators for their required fields. (aristanetworks#999)

* issue_997: BFD tests with proper validators

* improved the test coverage

* updated validator function

* addressed review commenrs: updated validator msgs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

Assignees

@vitthalmagadum vitthalmagadum

Labels
rn: fix(anta.tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AntaTest.Input subclasses using common input models should have validators for their required fields.
2 participants
@vitthalmagadum @carl-baillargeon