wip: Compatibility in Project.toml #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajkeller34
changed the title
|
Hmm, wasn't expecting the test failure, so definitely don't merge this for now... |
|
I'm still getting up to speed with understanding the Project.toml files and all that, so sorry for the noise. In any case, the PR is now much more conservative and just allows the package to work with StaticArrays 0.11 in addition to 0.10. |
arlk
added a commit
to arlk/ConvexBodyProximityQueries.jl
that referenced
this pull request
Jul 5, 2019
This should fix the test failure in arlk/CurveProximityQueries.jl#8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split this out into a separate PR because I wasn't sure if this was an intentional decision on your part, but I wanted to suggest removing the upper limits on dependency versions.
I think as written before this PR, the syntax implies the exact versions are required.edit: it does not. Some minor explanations:I believe the caretedit: this is already the default behavior^I added in front of the Julia version just means your package will be permitted to work with any version of Julia ≥ 1.0 and < 2.0, when Julia is next allowed to make breaking changes.It would at least be nice to loosen the bound on ConvexBodyProximityQueries, if notedit: this is already the default behavior≥ 0.1as I've done below then^0.1so that versions up to0.2are available.JuliaRegistries/Generalto retroactively upper-bound the compatibility.I made this PR because I had some conflict where I couldn't add your package the first time I tried it; another package I was using in the same environment wanted StaticArrays v0.11.