-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Light Theme #13
base: main
Are you sure you want to change the base?
Light Theme #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but I think this PR needs some changes before merging to master.
- Most important: the light/dark theme switcher is now broken. It seems that the light theme is your intended theme but if I switch to dark theme then the background colors stay the same and the text colors get light. In this mode the texts aren't readable anymore.
- Do you have chosen a different background color in comparison to arma.events to allow some kind of contrast between the arma.events screenshots and the background in docs.arma.events? Perhaps there are other solutions to that problem like a border around every image or a drop shadow.
- The font weight is very thin. It's a bit hard to read. Could you increase font weight?
- The green font in code blocks has an even harder readability. Perhaps increasing font weight globally would solve this issue too.
- The round image corners look good. But there are missing for videos. See 5 videos in the slotlist article.
Looks much better now. |
@y0014984 can you check again if you find obvious mistakes? |
@nomisum All in all it looks quite good. But some final annotations: Is it intentional to leave the blue buttons on the start screen in blue color (http://localhost:5173/en/)? The black bar of the arma.events logo is barely visible in dark mode on typical pages. Light mode uses a darkened box. Perhaps dark mode could you a lightened box. We could increase the headline of the warning boxes. It's currently very similar to the copy text of the box. Perhaps a more bold font style would help. Drop shadow around smaller tables looks weird. |
yes and no, i need an exception for this. brand color 2 is used here and to make them green i dont want to add another green as brand color (as blue makes sense in other contexts). its solvable though.
not sure what this is referring to, the divider? i prefer it to be subtle but could be nudged up a tiny bit.
its actually intentional to make them less large and dominant as they carry little information. is it possible to change the title content in markdown? the default text is kind of useless.
hard to solve as large tables profit. we might nudge the intensity down. |
i've updated the colors to reflect the actual platform colors. can you give it a sanity check @y0014984 ? |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
alles comments addressed. btw why is the crown blue instead of yellow in the table? 🤔 |
I don't know why. I think I used the highlight color from the original theme. We need to import the icon font from arma.events which allows us to easily use the icons. Currently, the crown is only an inline image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments above. The is still some work to do.
todo: