fix camera drivers for imx219 and ov5647

[bmx666]

No description provided.

[amazingfate]

This seems to be an override from other driver code, is the source available?

[bmx666]

@amazingfate not sure, I found it randomly in @Joshua-Riek repo and I mentioned that in commits. Customer tested both camera on RK3568 and they works fine with patched drivers.
For imx219 - I found the similar commit in ChromiumOS - https://chromium.googlesource.com/chromiumos/third_party/kernel/+/factory-ryu-6486.14.B-chromeos-3.14/drivers/media/i2c/soc_camera/imx219.c
And kernel thread about imx219 - https://lore.kernel.org/all/09ab897e-79a9-ae44-4caa-93d8d1fa1c51@synopsys.com/T/

[bmx666]

When I tried to find the issue why upstream imx219 and ov5647 drivers don't work on Rockchip, it's because they seems only compatible with Raspberry PI Broadcom CSI. I also could confirm that these upstream drivers don't work with imx6/imx8 boards and need to be patched as well - https://github.com/nxp-imx-support/meta-imx8mp-isp-imx219/blob/LF6.6.3_P24.1/recipes-kernel/kernel-modules/imx219/0001-isp-vvcam-add-imx219.patch

[amazingfate]

Let's merge it since the original drivers do not work.

[bmx666]

I found extra info about how to adopt camera drivers for Rockchip
https://hackaday.io/project/192267-open360camera/log/222791-drivers

RockChip extends base driver requirements with couple vendor-specific requirements.

• private ioctl calls RKMODULE_GET_MODULE_INFO, RKMODULE_SET_QUICK_STREAM
• bunch of specific v4l2 callbacks, such as enum_bus_code, enum_frame_size, s_stream

And from Rockchip documentation minimal steps to adopt CIS driver
https://docs.google.com/document/d/1QwTW4pzR1_6AQCFrgQtbIl26qkizEArC/edit#bookmark=id.3o7alnk

[bmx666]

@amazingfate found another critical issue - all defined camera drivers (in overlays/dtb) must be defined as build-in in kernel config. If camera driver defined as module it will not work correctly. idk, seems Rockchip initialize MIPI-CSI2 / CIF / ISP much early that modules and that affects boot sequence.
I'm currently working on another camera ov5460 for customers.

[amazingfate]

@amazingfate found another critical issue - all defined camera drivers (in overlays/dtb) must be defined as build-in in kernel config. If camera driver defined as module it will not work correctly. idk, seems Rockchip initialize MIPI-CSI2 / CIF / ISP much early that modules and that affects boot sequence.
I'm currently working on another camera ov5460 for customers.

What about adding driver module to initramfs?

[bmx666]

@amazingfate found another critical issue - all defined camera drivers (in overlays/dtb) must be defined as build-in in kernel config. If camera driver defined as module it will not work correctly. idk, seems Rockchip initialize MIPI-CSI2 / CIF / ISP much early that modules and that affects boot sequence.
I'm currently working on another camera ov5460 for customers.

What about adding driver module to initramfs?

OV5647 and IMX219 already defined as build-in in kernel config