Add logger in fixity script #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaceafill
requested changes
Sep 17, 2024
There was a problem hiding this comment.
This looks like good progress @Dhwaniartefact.
Looking at your tests changes I think we should keep asserting against the capsys fixture everywhere. The logger is just an implementation detail of your feature at this point.
Dhwaniartefact
force-pushed
the
dev/issue-add-logger-in-fixity-module
branch
3 times, most recently
from
6df3901 to
a1b6a1d
Compare
Dhwaniartefact
force-pushed
the
dev/issue-add-logger-in-fixity-module
branch
from
a1b6a1d to
06d582d
Compare
replaceafill
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove pyprint from
utils.pyand apply logger into fixity