Add type annotations for test_reporting #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixity/reporting.py
Outdated
Comment on lines
66
to
67
| report: Optional[Report], | ||
| report_url: Optional[str], |
There was a problem hiding this comment.
Some tests are setting as report=None and report_url=None.
There was a problem hiding this comment.
What do you think if we focus on the actual use from the fixity package and adjust the tests accordingly if needed?
There was a problem hiding this comment.
ya let me adjust the tests which focus on the actual use of the codes.
fixity/reporting.py
Outdated
Comment on lines
19
to
20
| start_time: Optional[datetime], | ||
| report_url: Optional[str], |
There was a problem hiding this comment.
Same answer as above.
There was a problem hiding this comment.
Good one. :) I got your point. Let me adjust the tests.
Dhwaniartefact
force-pushed
the
dev/issue-add-type-hints-test-reporting
branch
from
ce500f8 to
28c4c83
Compare
fixity/reporting.py
Outdated
| aip: str, | ||
| start_time: datetime, | ||
| report_url: str, | ||
| report_auth: str = (), |
There was a problem hiding this comment.
Why is this typed as str when it expects a tuple?
There was a problem hiding this comment.
Aah yes, I missed to see this.
Dhwaniartefact
force-pushed
the
dev/issue-add-type-hints-test-reporting
branch
2 times, most recently
from
8ca032e to
cc741e7
Compare
Dhwaniartefact
force-pushed
the
dev/issue-add-type-hints-test-reporting
branch
from
cc741e7 to
00b205f
Compare
|
We will annotate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.