Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include neglect expansion option in grid boundary dist calc #101

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Include neglect expansion option in grid boundary dist calc #101

wants to merge 2 commits into from

Conversation

gleck97
Copy link
Contributor

@gleck97 gleck97 commented Aug 7, 2024

No description provided.

@gleck97 gleck97 requested a review from lukeshingles as a code owner August 7, 2024 14:27
@lukeshingles lukeshingles force-pushed the develop branch 3 times, most recently from a434b42 to ec46b73 Compare September 4, 2024 15:00
@lukeshingles
Copy link
Member

This is an approximate way to neglect expansion (using a faster speed of light) and affects a critical part of the code. if you can use templates to avoid any performance cost and really remove the expansion factors, then I could merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeshingles lukeshingles Awaiting requested review from lukeshingles lukeshingles is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gleck97 @lukeshingles