Fix link to GTest if GTest is found via find_package #305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @artivis for the new tag! I was updating the release in conda-forge, and I took the occasion to re-enable the tests there on Windows.
I noticed that the 0.0.5 for us build was failing with an error related to gtest:
So I took the occasion to cleanup the linking to gtest. I used
GTest::gtest
as imported target to link against, and remove theadd_dependencies
step as it is implicit intarget_link_libraries
.