Update Video.php (pimcore#15395)

* Update Video.php Pimcore\Model\Asset\Video::getThumbnailConfig(): Argument #1 ($config) must be of type Pimcore\Model\Asset\Video\Thumbnail\Config|string, null given, called in /var/www/html/vendor/pimcore/pimcore/models/Document/Editable/Video.php on line 492 File: /var/www/html/vendor/pimcore/pimcore/models/Asset/Video.php Line: 73 * Update Video.php strpos(): Argument #1 ($haystack) must be of type string, int given File: /var/www/html/vendor/pimcore/pimcore/models/Document/Editable/Video.php Line: 938 some values arent strings
aryaantony92 · Jul 18, 2023 · 9f09132 · 9f09132
1 parent 35c2b6c
commit 9f09132
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/models/Asset/Video.php b/models/Asset/Video.php
@@ -64,13 +64,13 @@ public function clearThumbnails(bool $force = false): void
     /**
      * @internal
      *
-     * @param string|Video\Thumbnail\Config $config
+     * @param null|string|Video\Thumbnail\Config $config
      *
      * @return Video\Thumbnail\Config|null
      *
      * @throws Model\Exception\NotFoundException
      */
-    public function getThumbnailConfig(string|Video\Thumbnail\Config $config): ?Video\Thumbnail\Config
+    public function getThumbnailConfig(null|string|Video\Thumbnail\Config $config): ?Video\Thumbnail\Config
     {
         $thumbnail = null;
 

diff --git a/models/Document/Editable/Video.php b/models/Document/Editable/Video.php
@@ -935,7 +935,7 @@ private function getHtml5Code(array $urls = [], Asset\Video\ImageThumbnail|Asset
                 $attributesString .= ' ' . $key;
                 if (!empty($value)) {
                     $quoteChar = '"';
-                    if (strpos($value, '"')) {
+                    if (is_string($value) && strpos($value, '"')) {
                         $quoteChar = "'";
                     }
                     $attributesString .= '=' . $quoteChar . $value . $quoteChar;