Skip to content

Commit

Permalink
Add easy build and execution instructions for developers
Browse files Browse the repository at this point in the history
  • Loading branch information
Ayowel committed Jul 17, 2021
1 parent 5648eb1 commit c7ce5da
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 5 deletions.
6 changes: 6 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@ We welcome any type of contribution, not only code. You can help with

Working on your first Pull Request? You can learn how from this *free* series, [How to Contribute to an Open Source Project on GitHub](https://egghead.io/series/how-to-contribute-to-an-open-source-project-on-github).

## Getting started with the code

To start development of a new feature or fix, check out the repository with Git and start editing the code in your favorite IDE.

Once you're done editing, you will need a Java 16 JDK as well as Maven to build and run the code. Ensure that the `JAVA_HOME` environment variable is set to your Java 16 JDK path and run the following command to build and execute Asciidocfx: `mvn clean javafx:run -Djavafx.scope=compile`

## Submitting code

Any code change should be submitted as a pull request. The description should explain what the code does and give steps to execute it. The pull request should also contain tests.
Expand Down
20 changes: 15 additions & 5 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<asciidocfx.mainClass>com.kodedu.boot.AppStarter</asciidocfx.mainClass>
<java.version>16</java.version>
<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
Expand All @@ -21,6 +22,7 @@
<openjfx.version>16</openjfx.version>
<ikonli.version>12.2.0</ikonli.version>
<jaxb.version>2.3.2</jaxb.version>
<javafx.scope>provided</javafx.scope>
</properties>

<organization>
Expand Down Expand Up @@ -222,25 +224,25 @@
<groupId>org.openjfx</groupId>
<artifactId>javafx-swing</artifactId>
<version>${openjfx.version}</version>
<scope>provided</scope>
<scope>${javafx.scope}</scope>
</dependency>
<dependency>
<groupId>org.openjfx</groupId>
<artifactId>javafx-controls</artifactId>
<version>${openjfx.version}</version>
<scope>provided</scope>
<scope>${javafx.scope}</scope>
</dependency>
<dependency>
<groupId>org.openjfx</groupId>
<artifactId>javafx-web</artifactId>
<version>${openjfx.version}</version>
<scope>provided</scope>
<scope>${javafx.scope}</scope>
</dependency>
<dependency>
<groupId>org.openjfx</groupId>
<artifactId>javafx-fxml</artifactId>
<version>${openjfx.version}</version>
<scope>provided</scope>
<scope>${javafx.scope}</scope>
</dependency>

</dependencies>
Expand Down Expand Up @@ -288,7 +290,7 @@
<configuration>
<programs>
<program>
<mainClass>com.kodedu.boot.AppStarter</mainClass>
<mainClass>${asciidocfx.mainClass}</mainClass>
<id>asciidocfx</id>
</program>
</programs>
Expand Down Expand Up @@ -430,6 +432,14 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.openjfx</groupId>
<artifactId>javafx-maven-plugin</artifactId>
<version>0.0.6</version>
<configuration>
<mainClass>${asciidocfx.mainClass}</mainClass>
</configuration>
</plugin>
</plugins>
</build>

Expand Down

0 comments on commit c7ce5da

Please sign in to comment.