Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reader, writer, importer and exporter to directory #38

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

gimmyxd
Copy link
Member

@gimmyxd gimmyxd commented Nov 8, 2023

Adds the ability to configure the Reader, Writer, Exporter, Importer clients independently.

@gimmyxd gimmyxd force-pushed the expand_directory_config branch from 96e865a to ef7f493 Compare November 8, 2023 10:57
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (4edba50) 80.73% compared to head (c44362f) 68.90%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #38       +/-   ##
===========================================
- Coverage   80.73%   68.90%   -11.83%     
===========================================
  Files          22       23        +1     
  Lines         519      685      +166     
  Branches      163      207       +44     
===========================================
+ Hits          419      472       +53     
- Misses        100      213      +113     
Files Coverage Δ
lib/ds.ts 31.92% <82.60%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gimmyxd gimmyxd requested review from ronenh and ogazitt November 8, 2023 11:00
@gimmyxd gimmyxd merged commit ec0e9a9 into main Nov 14, 2023
4 checks passed
@gimmyxd gimmyxd deleted the expand_directory_config branch November 14, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants