Logging update. Fixed regression and update to Docker log handling. #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kga245
commented
Jan 7, 2025
•
kga245
commented
- Event logging fixed to populate JSON log (appears to have been a regression recently re-introduced.
- Added tests to make sure event logging creates a requesite file.
- Changed way docker logs font issues from WeasyPrint to be less verbose.
Problem: - Main application wasn't properly logging research events to output files - Log files were being created but weren't capturing events Solution: - Fixed researcher initialization chain in main application - Modified run_agent() to properly use CustomLogsHandler - Events now correctly captured in output files Testing: - Verified through uvicorn main:app --reload - Events properly logged to outputs/task_*.json
- Add test to verify researcher event logging - Test ensures events are properly captured in output files - Validates log file structure and content - Confirms proper initialization of CustomLogsHandler
- Added explicit logging level configuration in docker-compose.yml - Suppressed verbose fontTools logging messages in main.py
kga245
changed the title
|
Noticed that logs didn't sync to OS when using docker. Wanted to expose those and all outputs when running docker. |
|
Hey @kga245 can i merge this after tests? |
|
Yep, I expected that! |
|
FWIW I am bringing in a full-time tester. We're going to put this on the rails! |
|
FYI, running as uvicorn/fastapi on a heroku dyno produces some very verbose logs which is actually desired behavior. I didn't anticipate that but it's a happy accident. |
|
So excited to have you onboard! @kga245 🚀 |
assafelovic
approved these changes
Jan 9, 2025
|
Thank you for raising this issue! I'll look into it and try to help if I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.