Device options: allow to change MQTT connection keepalive value #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the user to specify a MQTT connection keepalive value different from the default one (30 sec). Increasing the keepalive will reduce network traffic, but it will take longer to notice that connection went off. The default value is 30s so as to mantain the previous behaviour. Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 39.98% 40.08% +0.10%
==========================================
Files 7 7
Lines 1158 1160 +2
==========================================
+ Hits 463 465 +2
Misses 592 592
Partials 103 103
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
matt-mazzucato
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the user to specify a MQTT connection keepalive value different from the default one (30 sec).
Increasing the keepalive will reduce network traffic, but it will take longer to notice that connection went off.
The default value is 30s so as to mantain the previous behaviour.