Skip to content
This repository has been archived by the owner on Aug 20, 2019. It is now read-only.

Change sidebar background from gray to green #76

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

ataylorme
Copy link
Owner

@ataylorme ataylorme commented Sep 28, 2017

Green is much prettier than gray.

@ataylorme

This comment has been minimized.

@ataylorme

This comment has been minimized.

@ataylorme

This comment has been minimized.

@ataylorme

This comment has been minimized.

@ataylorme

This comment has been minimized.

@ataylorme

This comment has been minimized.

greg-1-anderson
greg-1-anderson previously approved these changes Sep 5, 2018
Copy link
Collaborator

@greg-1-anderson greg-1-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Green is much better than gray.

@ataylorme

This comment has been minimized.

@ataylorme

This comment has been minimized.

@ataylorme

This comment has been minimized.

@ataylorme

This comment has been minimized.

A lighter background color should make the black test more legible.
@ataylorme
Copy link
Owner Author

Lighthouse test passed! The score of 87 isn't less than the acceptable score of 69 (5 less than the score of 74 on the master branch)

View the full Lighthouse performance report for green-sb and compare it to the Lighthouse performance report for the master branch

@ataylorme
Copy link
Owner Author

Visual regression test failed! Visual report

@ataylorme
Copy link
Owner Author

Lighthouse test passed! The score of 87 isn't less than the acceptable score of 75 (5 less than the score of 80 on the master branch)

View the full Lighthouse performance report for green-sb and compare it to the Lighthouse performance report for the master branch

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants