Skip to content
This repository has been archived by the owner on Mar 3, 2021. It is now read-only.

Fix multirun execution of scripts #83

Closed
wants to merge 1 commit into from
Closed

Fix multirun execution of scripts #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion multirun/def.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def _multirun_impl(ctx):
runfiles = runfiles.merge(default_runfiles)
commands.append(struct(
tag = tag,
path = exe.short_path,
path = "./" + exe.short_path,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a better approach would be to resolve relative paths in the instructions file taking the directory of that file as the base.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried this but it's not that straightforward because the path of the instruction file is relative to the exec root (or whatever) and it's just not worth the effort to do this.

))
instructions = struct(
commands = commands,
Expand Down