This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Relax the too restrictive begin expression for catch block #217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Relax the too restrictive begin expression for catch block for following reasons:
catch
and(
would also break the highlighting.Leave the catch keyword be would just be fine, since syntax highlighting should only be responsible for happy path.
Alternate Designs
Any other design would introduce new complexity.
Benefits
catch
catch
and '('Possible Drawbacks
More like a
right
hightlight for wrong syntax in code.Applicable Issues
Fix #205
FIx microsoft/vscode-java-pack#259