Add all Esp32-xx BOOTLOADER_OFFSET #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermm
changed the title
petermm
force-pushed
the
fix-S2-bootloader_offset
branch
from
6c66dab to
d07787e
Compare
bettio
requested changes
Mar 1, 2024
Esp32-S2 Offset was not correct - this PR adds all offsets as documented here: https://docs.espressif.com/projects/esp-idf/en/latest/esp32s2/api-guides/bootloader.html Signed-off-by: Peter M <petermm@gmail.com>
petermm
force-pushed
the
fix-S2-bootloader_offset
branch
from
d07787e to
f895c41
Compare
bettio
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to add all BOOTLOADER_OFFSET - and not only correcting the incorrect S2 one..
Obviously the conditional could be refactored, but seems preferably to explicitly list/config the various devices.
Release image didn't boot Esp32-S2.
"Bootloader is located at the address 0x1000 in the flash."https://docs.espressif.com/projects/esp-idf/en/latest/esp32s2/api-guides/bootloader.html
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later