Fix slow SNTP sync from cold boot #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettio
reviewed
Oct 13, 2024
UncleGrumpy
reviewed
Oct 14, 2024
petermm
force-pushed
the
fix-slow-cold-sntp
branch
from
32866a1 to
e1e48ea
Compare
petermm
force-pushed
the
fix-slow-cold-sntp
branch
from
e1e48ea to
5e87f99
Compare
petermm
force-pushed
the
fix-slow-cold-sntp
branch
from
5e87f99 to
523b773
Compare
bettio
requested changes
Dec 21, 2024
petermm
force-pushed
the
fix-slow-cold-sntp
branch
2 times, most recently
from
0d3cd7d to
f2b2f83
Compare
using ap_sta_network example https://github.com/atomvm/AtomVM/blob/release-0.6/examples/erlang/esp32/ap_sta_network.erl testing on real devices (and hundreds of wokwi ci runs) - a cold boot often produces a significant wait for sntp sync: 20-30 seconds. calling esp_sntp_restart() on the got_ip event fixes this. the function is noop if sntp is not init'ed/config'ed. https://github.com/espressif/esp-idf/blob/707d097b01756687cca18be855a2675d150247ae/components/lwip/apps/sntp/sntp.c#L123 Signed-off-by: Peter M <petermm@gmail.com>
petermm
force-pushed
the
fix-slow-cold-sntp
branch
from
f2b2f83 to
ea27233
Compare
|
Should we land this in release-0.6? |
No, honestly I would just add urgent fixes to release-0.6, documentation improvements or any CI tweaking. |
bettio
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using ap_sta_network example https://github.com/atomvm/AtomVM/blob/release-0.6/examples/erlang/esp32/ap_sta_network.erl
testing on real devices (and hundreds of wokwi ci runs) - a cold boot often produces a significant wait for sntp sync: 20-30 seconds.
calling esp_sntp_restart() on the got_ip event fixes this. the function is noop if sntp is not init'ed/config'ed. https://github.com/espressif/esp-idf/blob/707d097b01756687cca18be855a2675d150247ae/components/lwip/apps/sntp/sntp.c#L123
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later