Fix broken ESP32 gpio interrupt trigger none
#1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the implementation of the `none` trigger that has been documented since release-0.5, but was apparently never tested, its use causes a error (see atomvm#1386). Moves the main functionality from `gpiodriver_remove_int` into a new `unregister_interrupt_listener` funtion that is also used when setting the interrupt trigger to `none` to remove an interrupt. Closes atomvm#1386 Signed-off-by: Winford <winford@object.stream>
bettio
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the implementation of the
nonetrigger that has been documented since release-0.5, but was apparently never tested, its use causes a error (see #1386).Moves the main functionality from
gpiodriver_remove_intinto a newunregister_interrupt_listenerfuntion that is also used when setting the interrupt trigger tononeto remove an interrupt.Closes #1386
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later