Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add socket:getopt/2 #1422

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Add socket:getopt/2 #1422

merged 1 commit into from
Dec 27, 2024

Conversation

pguyot
Copy link
Collaborator

@pguyot pguyot commented Dec 26, 2024

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

@pguyot pguyot force-pushed the w52/add-socket-getopt branch from f348d7c to e9b5cb7 Compare December 26, 2024 20:41
Copy link
Collaborator

@bettio bettio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1421 has been merged into main, and this PR looks good. As soon as it is undrafted I can merge it in main without further reviews.

@pguyot pguyot changed the base branch from feature/distributed-erlang to main December 27, 2024 19:25
@pguyot pguyot force-pushed the w52/add-socket-getopt branch from e9b5cb7 to 1271008 Compare December 27, 2024 19:25
@pguyot pguyot marked this pull request as ready for review December 27, 2024 19:25
Also fix error tuple of `socket:setopt/3` to be `{error, closed}` following
OTP.

Signed-off-by: Paul Guyot <pguyot@kallisys.net>
@pguyot pguyot force-pushed the w52/add-socket-getopt branch from 1271008 to 14a3a37 Compare December 27, 2024 19:49
@bettio bettio merged commit 74258a1 into atomvm:main Dec 27, 2024
104 checks passed
@pguyot pguyot deleted the w52/add-socket-getopt branch December 28, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants