Implement lists:reverse/1,2 as nif
#806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguyot
force-pushed
the
w34/implement-lists-reverse-as-nif
branch
from
1d02c86 to
11afecd
Compare
fadushin
reviewed
Oct 29, 2023
|
I think I checked all cases looking at disassembly and the non-tail recursion versions were more or as efficient memory wise. |
fadushin
approved these changes
Oct 29, 2023
bettio
requested changes
Oct 30, 2023
Also rewrite several lists module functions to not use this nif, either because it was not necessary (lists:seq/2,3) or because a non-tail recursive loop is more efficient memory-wise. Signed-off-by: Paul Guyot <pguyot@kallisys.net>
pguyot
force-pushed
the
w34/implement-lists-reverse-as-nif
branch
from
11afecd to
5817b40
Compare
bettio
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This nif does not need to be updated after #795 is merged.
Also rewrite several lists module functions to not use this nif, either because
it was not necessary (
lists:seq/2,3) or because a non-tail recursive loopis more efficient memory-wise.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later