Implement esp:get_default_mac/0 based on esp_efuse_mac_get_default
#973
Conversation
| esp_err_t err = esp_efuse_mac_get_default(mac); | ||
| if (err != ESP_OK) { | ||
| ESP_LOGE(TAG, "Unable to read default mac. err=%i", err); | ||
| RAISE_ERROR(ERROR_ATOM); |
There was a problem hiding this comment.
I am a bit torn about this, because I can see that we made the same mistake in the definition of get_mac. What I would prefer is that we return {error, Reason :: term()}, where reason in this case is some sort of mnemonic atom, mapped from the esp_err_t.
The question is whether we make the fix here, or whether we follow up with a subsequent PR that addresses both functions.
Let's at least put a TODO comment in this code, so that we know to address it in the future, and file an issue in GitHub to that effect.
There was a problem hiding this comment.
Fine by me. I'll add a TODO in this PR and create an issue about the API change.
There was a problem hiding this comment.
Sorry for the confusion here, I'd rather go with {ok, Result} | {error, Reason} already with this function.
So we reduce API changes in advance (and we make less boring future work for adapting existing functions also for us).
There was a problem hiding this comment.
Alright, and I'll include the API change for get_mac in the current PR too, right?
There was a problem hiding this comment.
I suggest the following:
- adopt the new API for
esp:get_default_mac/0for the reason I mentioned. It is a new function so no breaking API change will happen - keep
get_mac/1as is, since changing return type would break existing API, and we are approaching v0.6.0 so I'd like to keep existing API frozen.
Add `get_default_mac` function to retrieve the default MAC address from the EFUSE block of the ESP32 chip. This function utilizes the `esp_efuse_mac_get_default` API to access the factory-programmed MAC address. Signed-off-by: tovam <tovam@users.noreply.github.com>
tovam
force-pushed
the
add-esp32-get-default-mac
branch
from
f37e789 to
3b779fe
Compare
|
I've just pushed an updated version, does the code look good to you? |
Add
get_default_macfunction to retrieve the default MAC address from the EFUSE block of the ESP32 chip. This function utilizes theesp_efuse_mac_get_defaultAPI to access the factory-programmed MAC address.These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later