port: add helper function for parsing message tuple #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettio
force-pushed
the
change-port-call-tuple
branch
from
a2cc409 to
cf1fbdd
Compare
bettio
force-pushed
the
change-port-call-tuple
branch
2 times, most recently
from
1b313b1 to
47c8c60
Compare
bettio
force-pushed
the
change-port-call-tuple
branch
2 times, most recently
from
4332144 to
7358e20
Compare
bettio
changed the title
bettio
changed the title
bettio
force-pushed
the
change-port-call-tuple
branch
3 times, most recently
from
17fb7de to
14197e2
Compare
Remove duplicate code and add checks. Signed-off-by: Davide Bettio <davide@uninstall.it>
Future proof #2: return the type of message instead of a generic Ok value. Right now we support only calls. Signed-off-by: Davide Bettio <davide@uninstall.it>
bettio
force-pushed
the
change-port-call-tuple
branch
from
1cfd28b to
804ff69
Compare
bettio
changed the title
fadushin
approved these changes
Dec 26, 2023
|
|
||
| term pid; | ||
| term ref; | ||
| } GenMessage; |
There was a problem hiding this comment.
Not all messages will have a ref or even a pid. Are we okay with this? I am fine with it, and I consider this a kind of interim solution, so that's fine. Just thinking ahead to what an $info or $cast message would look like.
This is just an observation, not a change request.
There was a problem hiding this comment.
In that case GenCastMessage instead of GenCallMessage will be returned (pid and ref will be invalid).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add function for hiding port message tuple format details, so code doesn't need to hardcode indexes or repeat always the same checks, that can be instead shared across different port drivers.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later