Feature/improve existing methods #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsur753
reviewed
Dec 6, 2021
| if(isConnected){ | ||
| return usbDevice.getProductName(); | ||
| } else { | ||
| return ""; |
There was a problem hiding this comment.
Perhaps it's good to return some message or error instead of empty string
| public boolean isSensorOnline(String sensorName){ | ||
| return sensorStatus.get(sensorName); | ||
| } | ||
|
|
||
| public boolean isHumidityOnline() { |
There was a problem hiding this comment.
These getters seem a bit redundant now that we have a more generic accessor. I guess they could still be useful.. probably good to clarify in README
| QueueReader queueReader; | ||
|
|
||
| private QueueWriter queueWriter; | ||
| private QueueReader queueReader; | ||
|
|
||
| public KiwriousCallback SensorConnected; |
There was a problem hiding this comment.
Defined but never used. Currently this would be dead code since we don't yet refer the callback function in our Usb Serial code. Maybe we hide this for now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.