Fix duplicate period #118
Open
Fix duplicate period #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
|
Yes, I need someone's review. |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for developing such an awesome product!
I noticed a small problem and tried to fix it. Please review :)
✏️ Changes
If we select a Japanese locale for the Account Link UI, the actual message is a bit weird...
。means a period in Japanese, and currently,identitiesinjalocale has。and the others don't have a period (.) in the sentence.Seeing the
identitiespart in the actual view, it includes., so if we use Japanese, there are two periods in the constructed message (like...ログインできるようになります。.).This PR adjusts the locales and the template so that all locales work fine!
📷 Screenshots
If there were visual changes to the application with this change, please include before and after screenshots here. If it has animation, please use screen capture software like to make a gif.
🔗 References
🎯 Testing
✅🚫 This change has been tested in a Webtask
✅🚫 This change has unit test coverage
✅🚫 This change has integration test coverage
✅🚫 This change has been tested for performance
🚀 Deployment
✅🚫 This can be deployed any time
🎡 Rollout
🔥 Rollback
📄 Procedure
🖥 Appliance