-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use rules config #78
base: master
Are you sure you want to change the base?
use rules config #78
Conversation
This reverts commit 240d59c.
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
yes it's still relevant, I am waiting a review from an employee of Auth0 |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
are you even reading pull requests? |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
I don't use this addon anymore as it seems that you don't care about it |
✏️ Changes
following the last recommendation about automatic linking identities. As recommended, we wanted to use this extension. As we use a custom domain and the rest of the Auth0 configuration is managed through Terraform, we want to ease future migration. We think that rules configs are exactly there to fix this problem, as with rules configs, we don't need to change anymore the rule itself.
The rule can now be always the same and configured at run time thanks to rules configs.
🔗 References
remove secret from source code #77
allow to edit the custom domain without changing the rule #59
🎯 Testing
as Webtask seems to be deprecated, it's difficult to test.
✅🚫 This change has been tested in a Webtask
✅🚫 This change has unit test coverage
✅🚫 This change has integration test coverage
✅🚫 This change has been tested for performance
🚀 Deployment
the deployment of this change can be done at any time. for the last time user with custom domain will need to do a manipulation, they will need to set the rules config
customDomain
. at that time, we can also apply the following change in the documentation.✅ This can be deployed any time
🎡 Rollout
In order to verify that the deployment was successful we will …
🔥 Rollback
We will rollback if …
📄 Procedure
🖥 Appliance
Note to reviewers: ensure that this change is compatible with the Appliance.