Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rules config #78

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Conversation

gagalago
Copy link

@gagalago gagalago commented Jul 28, 2020

✏️ Changes

following the last recommendation about automatic linking identities. As recommended, we wanted to use this extension. As we use a custom domain and the rest of the Auth0 configuration is managed through Terraform, we want to ease future migration. We think that rules configs are exactly there to fix this problem, as with rules configs, we don't need to change anymore the rule itself.
The rule can now be always the same and configured at run time thanks to rules configs.

🔗 References

remove secret from source code #77
allow to edit the custom domain without changing the rule #59

🎯 Testing

as Webtask seems to be deprecated, it's difficult to test.

Describe how this can be tested by reviewers. Please be specific about anything not tested and reasons why.

  • Make sure you add unit and integration tests.

✅🚫 This change has been tested in a Webtask

✅🚫 This change has unit test coverage

✅🚫 This change has integration test coverage

✅🚫 This change has been tested for performance

🚀 Deployment

the deployment of this change can be done at any time. for the last time user with custom domain will need to do a manipulation, they will need to set the rules config customDomain. at that time, we can also apply the following change in the documentation.

✅ This can be deployed any time

🎡 Rollout

Explain how the change will be verified once released. Manual testing? Functional testing?

In order to verify that the deployment was successful we will …

🔥 Rollback

Explain when and why we will rollback the change.

We will rollback if …

📄 Procedure

Explain how the rollback for this change will look like, how we can recover fast.

🖥 Appliance

Note to reviewers: ensure that this change is compatible with the Appliance.

@gagalago gagalago marked this pull request as ready for review September 9, 2020 11:53
@stale
Copy link

stale bot commented Jun 16, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Jun 16, 2021
@gagalago
Copy link
Author

yes it's still relevant, I am waiting a review from an employee of Auth0

@stale stale bot removed the wontfix label Jun 17, 2021
@stale
Copy link

stale bot commented Jan 9, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Jan 9, 2022
@gagalago
Copy link
Author

are you even reading pull requests?

@stale stale bot removed the wontfix label Jan 10, 2022
@stale
Copy link

stale bot commented Apr 16, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Apr 16, 2022
@gagalago
Copy link
Author

I don't use this addon anymore as it seems that you don't care about it

@stale stale bot removed the wontfix label Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant