Code review #140
Merged
Code review #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-muncke
reviewed
Jan 6, 2025
sam-muncke
reviewed
Jan 6, 2025
sam-muncke
reviewed
Jan 6, 2025
sam-muncke
approved these changes
Jan 8, 2025
ionutmanolache-okta
added a commit
that referenced
this pull request
Jan 9, 2025
* Fix flakey JWT test * Adds implementation of Consent API client for retrieving rich-consents for CIBA flow * Add failure case test to ConsentSpec * Small changes to align with Android SDK implementation * Add README section for fetching consent * Code review (#140) * Code review * removed context path manipulation * Tests fixed * Changed method signature to correct --------- Co-authored-by: Ionut Manolache <ionut.manolache@okta.com> * backward compatibility with guardian domains --------- Co-authored-by: Artem Bakanov <artem.bakanov@okta.com> Co-authored-by: Ionut Manolache <ionut.manolache@okta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.