Use correct version of joi
#392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauntimo
changed the title
joi
fbgoode
reviewed
Oct 30, 2024
server/views/index.js
Outdated
| @@ -11,7 +11,7 @@ module.exports = `<!DOCTYPE html> | |||
| <link rel="stylesheet" type="text/css" href="https://cdn.auth0.com/styleguide/4.8.10/index.min.css" /> | |||
| <link rel="stylesheet" type="text/css" href="https://cdn.auth0.com/manage/v0.3.1672/css/index.min.css"> | |||
| <% if (assets.style) { %><link rel="stylesheet" type="text/css" href="<%= assets.style %>"><% } %> | |||
| <% if (assets.version) { %><link rel="stylesheet" type="text/css" href="//cdn.auth0.com/extensions/auth0-authz/assets/auth0-authz.ui.<%= assets.version %>.css"><% } %> | |||
| <% if (assets.version) { %><link rel="stylesheet" type="text/css" href="//cdn.auth0.com/extensions/develop/auth0-authz/assets/auth0-authz.ui.<%= assets.version %>.css"><% } %> | |||
There was a problem hiding this comment.
Should changes to this file be reverted?
There was a problem hiding this comment.
oooh yes, great spot, thank you!!
fbgoode
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ Changes
auth0-extension-hapi-toolsdep and brings some required code in to the repo as the original repo (sub)depended on an incompatible version ofjoiinertto@hapi/inertjoiinblippto the correct versionjoi@17.12.2which is now in canirequire (PR). This is the version whichhapi-swagger@17.2.1includes as a dependency in canirequire - see discussion here.📷 Screenshots
If there were visual changes to the application with this change, please include before and after screenshots here. If it has animation, please use screen capture software like to make a gif.
🔗 References
🎯 Testing
Tested manually in
prod-uk-1:🚀 Deployment
🚫 This will be built locally and deployed manually when the appropriate webtask changes have made it to prod