Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-741 Add support for configuring email provider #1120

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

acwest
Copy link
Contributor

@acwest acwest commented Jan 7, 2025

Auth0 provides integration capabilities with many email providers like sendgrid, mailgun, mandrill etc.
As an extension to this, it now also supports Custom Email Provider which is tied to an action.

🔧 Changes

Add auth0 email provider commands:

  • auth0 email provider show
  • auth0 email provider create
  • auth0 email provider update
  • auth0 email provider delete

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@acwest acwest requested a review from a team as a code owner January 7, 2025 19:42
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 68.11989% with 117 lines in your changes missing coverage. Please review.

Project coverage is 70.40%. Comparing base (c1d2c52) to head (a4839b0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/cli/email_provider.go 70.50% 61 Missing and 21 partials ⚠️
internal/display/email_provider.go 60.22% 27 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1120      +/-   ##
==========================================
+ Coverage   70.38%   70.40%   +0.01%     
==========================================
  Files          94       96       +2     
  Lines       13286    13653     +367     
==========================================
+ Hits         9352     9613     +261     
- Misses       3388     3466      +78     
- Partials      546      574      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acwest acwest force-pushed the DXCDT-741-add-custom-email-provider branch 6 times, most recently from c80a6fa to 1cb3b04 Compare January 10, 2025 16:14
@acwest acwest force-pushed the DXCDT-741-add-custom-email-provider branch from 1cb3b04 to 640204b Compare January 10, 2025 17:05
@kushalshit27
Copy link

Hi, @acwest ,
Is delete supported ?

https://auth0.com/docs/api/management/v2/emails/delete-provider - 404 Error

@acwest
Copy link
Contributor Author

acwest commented Jan 14, 2025

Hi, @acwest , Is delete supported ?

https://auth0.com/docs/api/management/v2/emails/delete-provider - 404 Error

That's interesting, delete is supported, but is apparently not documented. I will ask them about that...

Copy link

@kushalshit27 kushalshit27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@acwest acwest merged commit c62ee6c into main Jan 17, 2025
9 checks passed
@acwest acwest deleted the DXCDT-741-add-custom-email-provider branch January 17, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants