Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications in auth0 ul template update preview #895

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Nov 1, 2023

🔧 Changes

Adding notifications in the auth0 ul templates update command's legacy preview functionality to promote the new branding customization functionality. In due time, this messaging can become more aggressive and inform of deprecation/removal.

In UI
Screenshot 2023-11-01 at 3 19 36 PM

In CLI:
Screenshot 2023-11-01 at 4 14 31 PM

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner November 1, 2023 20:14
@willvedd willvedd changed the title Notification templates update command Notifications in auth0 ul template update preview Nov 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad1ff8c) 72.89% compared to head (348c126) 72.87%.

Additional details and impacted files
@@                             Coverage Diff                             @@
##           feature/auth0-universal-login-customize     #895      +/-   ##
===========================================================================
- Coverage                                    72.89%   72.87%   -0.02%     
===========================================================================
  Files                                           93       93              
  Lines                                        12335    12337       +2     
===========================================================================
- Hits                                          8992     8991       -1     
- Misses                                        2822     2824       +2     
- Partials                                       521      522       +1     
Files Coverage Δ
internal/cli/universal_login_templates.go 46.47% <100.00%> (+0.37%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sergiught sergiught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍🏻

The only thing I changed was the command suggestion. It should be "auth0 universal-login customize".

@sergiught sergiught merged commit 991514d into feature/auth0-universal-login-customize Nov 2, 2023
6 checks passed
@sergiught sergiught deleted the notification-templates-update-command branch November 2, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants